Merged
Conversation
saxon-milton
added a commit
that referenced
this pull request
May 29, 2025
Resolves #579 We can check the controller error variable first to easily get any error state. If the controller does not yet support this, we still check other pieces of information.
saxon-milton
force-pushed
the
low-voltage-improvements
branch
from
b2e875d to
e130e2a
Compare
scruzin
approved these changes
May 29, 2025
Collaborator
scruzin
left a comment
scruzin
left a comment
There was a problem hiding this comment.
Just one question, but LGTM.
ao-david
approved these changes
Jun 10, 2025
Member
ao-david
left a comment
ao-david
left a comment
There was a problem hiding this comment.
Few small comments about a comment
Resolves #579 We can check the controller error variable first to easily get any error state. If the controller does not yet support this, we still check other pieces of information.
saxon-milton
force-pushed
the
low-voltage-improvements
branch
from
e130e2a to
26ba135
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #579
We can check the controller error variable first to easily get any
error state. If the controller does not yet support this, we still
check other pieces of information.